fix: Prevent scrolling behind menus and modals in Safari iOS #35183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Jun 25, 2025
|
This looks great. Also didn't realize the menu was dismissible via swipe until this merged (maybe it wasn't before) but that's also a nice touch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
touch-action: none, thanks @renchap!)scrollbar-gutter: stable;to get rid of all the brittle scrollbar width detection we used to do. And we could also get rid of the style tag/attribute injectionScreenshots
Note
This video has no cursor so it's hard to see that I'm trying my best to make the page behind the menu scroll :)
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-06-25.at.21.06.53.mp4