fix: Improve a11y of custom select menus in notifications settings #35403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaosExAnima
approved these changes
Jul 17, 2025
oneiros
pushed a commit
that referenced
this pull request
Jul 21, 2025
oneiros
pushed a commit
that referenced
this pull request
Jul 23, 2025
SlyEcho
pushed a commit
to est-social/mastodon
that referenced
this pull request
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Dropdowncomponent accessibility #35373 to theSelectWithLabelcomponent, allowing screen reader users to access the menu's selected value as well as the menu's open/closed state. (Previously, both the label and description were announced as the button's label, overriding the button's content with the selected value.)