Remove deprecated Import model
#34371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5bcc93e to
cfc3a57
Compare
cfc3a57 to
534ce67
Compare
Just rebased/pushed and all seems fine ... what are you looking for there? |
|
It shouldn't be too much of an issue but the migration serial number defines when migrations run, and having a migration out of order like this may cause issues for us in the future if we add more breakpoints, like we did around 4.3.0. I would suggest bumping the migration serial number to a current-day value. |
534ce67 to
19408ad
Compare
|
Ah, I see -- bumped the migration timestamp to be today so that it's date range should fall more safely into version upgrade paths. |
ClearlyClaire
approved these changes
Apr 10, 2025
|
This will require some note in the 4.4.0 upgrade notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: #30345 (comment)