Fix extra space under left-indented vertical videos #34313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a reason this wrapper was added, I’m not 100% certain but I believe since the video is not passed width/height anymore without the aspect ratio it would cause a layout jump while it/poster image loads. |
|
The current behavior is that vertical videos in a thread look like that: I suppose this needs more testing, but the PR preserves the |
|
I have not been able to find a case where removing |
Gargron
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The video wrapping was forced to have the aspect ratio of the video itself, even when it has left-padding (because it is a reply or an ancestor in a thread), causing extra padding below the video.