Skip to content

Fix CacheBuster being queued for missing media attachments #34253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2025
Merged

Fix CacheBuster being queued for missing media attachments #34253

merged 2 commits into from
Mar 24, 2025

Conversation

ClearlyClaire
Copy link
Contributor

Fixes #34251

@ClearlyClaire ClearlyClaire marked this pull request as ready for review March 24, 2025 08:44
@ClearlyClaire ClearlyClaire requested a review from a team March 24, 2025 08:44
@ClearlyClaire ClearlyClaire added the to backport PR needed to be backported label Mar 24, 2025
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit ef87000 Mar 24, 2025
37 checks passed
@ClearlyClaire ClearlyClaire deleted the fixes/useless-missing-cache-buster branch March 24, 2025 09:07
vmstan pushed a commit to vmstan/mastodon that referenced this pull request Mar 27, 2025
@ClearlyClaire @vmstan
Fix CacheBuster being queued for missing media attachments (mastodo…
7543fbd 
…n#34253)
ClearlyClaire added a commit that referenced this pull request Mar 28, 2025
@ClearlyClaire
Fix CacheBuster being queued for missing media attachments (#34253)
6dea343
ClearlyClaire added a commit that referenced this pull request Mar 31, 2025
@ClearlyClaire
Fix CacheBuster being queued for missing media attachments (#34253)
8197e65
@ClearlyClaire ClearlyClaire mentioned this pull request Mar 31, 2025
Merged
@ClearlyClaire ClearlyClaire removed the to backport PR needed to be backported label Apr 2, 2025
kmycode pushed a commit to kmycode/mastodon that referenced this pull request Apr 2, 2025
@ClearlyClaire @kmycode
Fix CacheBuster being queued for missing media attachments (mastodo…
b84d2fc 
…n#34253)
robin-maki added a commit to byulmaru/mastodon that referenced this pull request Apr 6, 2025
@robin-maki
Squashed commit of the following:
f45d213 
commit 6f16011
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Wed Apr 2 09:14:21 2025 +0200

    Bump version to v4.3.7 (mastodon#34328)

commit 65a6840
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue Apr 1 10:53:49 2025 +0200

    Fix static version of animated PNG emojis not being properly extracted (mastodon#34337)

commit 527d920
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Apr 1 11:10:20 2025 +0200

    New Crowdin Translations for stable-4.3 (automated) (mastodon#34336)

    Co-authored-by: GitHub Actions <noreply@github.com>

commit 6d53e8c
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Fri Mar 28 16:30:28 2025 +0100

    Add delay to profile updates to debounce them (mastodon#34137)

commit d9fb61f
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Fri Mar 28 10:20:32 2025 +0100

    Change account suspensions to be federated to recently-followed accounts as well (mastodon#34294)

commit 6af733d
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Thu Mar 27 14:41:13 2025 +0100

    Change `AccountReachFinder` to consider statuses based on suspension date (mastodon#34291)

commit 29eae75
Author: Matt Jankowski <matt@jankowski.online>
Date:   Tue Nov 12 03:38:08 2024 -0500

    Define constants for sampling sizes in `AccountReachFinder` (mastodon#32805)

commit 8a3f25a
Author: David Roetzel <david@roetzel.de>
Date:   Wed Mar 26 14:26:24 2025 +0100

    Use fixed order in flaky spec (mastodon#34279)

commit 0615feb
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Wed Mar 26 12:33:59 2025 +0100

    Add support for paginating partial collections in `SynchronizeFollowersService` (mastodon#34277)

commit 86d8df0
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue Mar 25 16:50:05 2025 +0100

    Fix follower synchronization mechanism erroneously removing followers from multi-page collections (mastodon#34272)

commit 105e5b1
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue Mar 25 16:20:36 2025 +0100

    Fix bookmarks and favourites not being filtered (mastodon#34260)

commit d6442b5
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue Mar 25 14:11:49 2025 +0100

    Fix filters not applying in detailed view (mastodon#34259)

commit 653868b
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon Mar 24 10:59:05 2025 +0100

    Change user archive signed URL TTL from 10 seconds to 1 hour (mastodon#34254)

commit 4cb3fe3
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue Mar 18 15:50:41 2025 +0100

    Fix handling of malformed/unusual HTML (mastodon#34201)

commit 8197e65
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon Mar 24 09:58:15 2025 +0100

    Fix `CacheBuster` being queued for missing media attachments (mastodon#34253)

commit c48413a
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon Mar 17 17:40:28 2025 +0100

    Fix incorrect URL being used when cache busting (mastodon#34189)

commit 9be3915
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon Mar 24 15:07:27 2025 +0100

    Fix streaming server refusing unix socket path in `DATABASE_URL` (mastodon#34091)

commit 2340f4d
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Wed Jan 29 11:15:32 2025 +0100

    Fix “x” hotkey not working on boosted filtered posts (mastodon#33758)

commit cdcd77e
Author: David Roetzel <david@roetzel.de>
Date:   Thu Mar 13 13:32:38 2025 +0100

    Bump version to v4.3.6

commit c79c9e8
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Thu Mar 13 09:37:45 2025 +0100

    Update dependency `omniauth-saml`

commit e84031e
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Thu Mar 13 09:22:13 2025 +0100

    Update dependency `rack`

commit d01e407
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon Mar 10 15:27:43 2025 +0100

    Fix Stoplight errors when using `REDIS_NAMESPACE` (mastodon#34126)
robin-maki added a commit to byulmaru/mastodon that referenced this pull request May 8, 2025
@robin-maki
Squashed commit of the following:
adb05e2 
commit e6591bf
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue May 6 15:08:57 2025 +0200

    Fix code style issue

commit 30e25ff
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue May 6 08:39:08 2025 +0200

    Bump version to v4.3.8

commit 5ef82d7
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue May 6 08:27:36 2025 +0200

    Update dependency net-imap

commit e14bf63
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue May 6 08:26:43 2025 +0200

    Update dependency nokogiri

commit 6d46225
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue May 6 15:02:13 2025 +0200

    Merge commit from fork

    * Check scheme in account and post links

    * Harden media attachments

    * Client-side mitigation

    * Client-side mitigation for media attachments

commit ec20232
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon May 5 15:01:16 2025 +0200

    Add warning for REDIS_NAMESPACE deprecation at startup (mastodon#34581)

commit e6a6c26
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon May 5 15:13:08 2025 +0200

    Remove double-query for signed query strings (mastodon#34610)

commit 86a8aa5
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon May 5 15:12:07 2025 +0200

    Add built-in context for interaction policies (mastodon#34574)

commit a9f8b1a
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon May 5 15:11:26 2025 +0200

    Fix incorrect redirect in response to unauthenticated API requests in limited federation mode (mastodon#34549)

commit 698e4fd
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Fri Apr 25 11:00:54 2025 +0200

    Fix sign-up e-mail confirmation page reloading on error or redirect (mastodon#34548)

commit 72b1af1
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Fri Jan 17 10:12:59 2025 +0100

    Change activity distribution error handling to skip retrying for deleted accounts (mastodon#33617)

commit 6f16011
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Wed Apr 2 09:14:21 2025 +0200

    Bump version to v4.3.7 (mastodon#34328)

commit 65a6840
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue Apr 1 10:53:49 2025 +0200

    Fix static version of animated PNG emojis not being properly extracted (mastodon#34337)

commit 527d920
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Apr 1 11:10:20 2025 +0200

    New Crowdin Translations for stable-4.3 (automated) (mastodon#34336)

    Co-authored-by: GitHub Actions <noreply@github.com>

commit 6d53e8c
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Fri Mar 28 16:30:28 2025 +0100

    Add delay to profile updates to debounce them (mastodon#34137)

commit d9fb61f
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Fri Mar 28 10:20:32 2025 +0100

    Change account suspensions to be federated to recently-followed accounts as well (mastodon#34294)

commit 6af733d
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Thu Mar 27 14:41:13 2025 +0100

    Change `AccountReachFinder` to consider statuses based on suspension date (mastodon#34291)

commit 29eae75
Author: Matt Jankowski <matt@jankowski.online>
Date:   Tue Nov 12 03:38:08 2024 -0500

    Define constants for sampling sizes in `AccountReachFinder` (mastodon#32805)

commit 8a3f25a
Author: David Roetzel <david@roetzel.de>
Date:   Wed Mar 26 14:26:24 2025 +0100

    Use fixed order in flaky spec (mastodon#34279)

commit 0615feb
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Wed Mar 26 12:33:59 2025 +0100

    Add support for paginating partial collections in `SynchronizeFollowersService` (mastodon#34277)

commit 86d8df0
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue Mar 25 16:50:05 2025 +0100

    Fix follower synchronization mechanism erroneously removing followers from multi-page collections (mastodon#34272)

commit 105e5b1
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue Mar 25 16:20:36 2025 +0100

    Fix bookmarks and favourites not being filtered (mastodon#34260)

commit d6442b5
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue Mar 25 14:11:49 2025 +0100

    Fix filters not applying in detailed view (mastodon#34259)

commit 653868b
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon Mar 24 10:59:05 2025 +0100

    Change user archive signed URL TTL from 10 seconds to 1 hour (mastodon#34254)

commit 4cb3fe3
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Tue Mar 18 15:50:41 2025 +0100

    Fix handling of malformed/unusual HTML (mastodon#34201)

commit 8197e65
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon Mar 24 09:58:15 2025 +0100

    Fix `CacheBuster` being queued for missing media attachments (mastodon#34253)

commit c48413a
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon Mar 17 17:40:28 2025 +0100

    Fix incorrect URL being used when cache busting (mastodon#34189)

commit 9be3915
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon Mar 24 15:07:27 2025 +0100

    Fix streaming server refusing unix socket path in `DATABASE_URL` (mastodon#34091)

commit 2340f4d
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Wed Jan 29 11:15:32 2025 +0100

    Fix “x” hotkey not working on boosted filtered posts (mastodon#33758)

commit cdcd77e
Author: David Roetzel <david@roetzel.de>
Date:   Thu Mar 13 13:32:38 2025 +0100

    Bump version to v4.3.6

commit c79c9e8
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Thu Mar 13 09:37:45 2025 +0100

    Update dependency `omniauth-saml`

commit e84031e
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Thu Mar 13 09:22:13 2025 +0100

    Update dependency `rack`

commit d01e407
Author: Claire <claire.github-309c@sitedethib.com>
Date:   Mon Mar 10 15:27:43 2025 +0100

    Fix Stoplight errors when using `REDIS_NAMESPACE` (mastodon#34126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oneiros oneiros oneiros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too many CacheBuster queues after run tootctl
2 participants
@ClearlyClaire @oneiros