Skip to content

Fix premailer strategy when using CDN_HOST #34813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

Fix premailer strategy when using CDN_HOST #34813

merged 1 commit into from
May 26, 2025

Conversation

ClearlyClaire
Copy link
Contributor

Fixes #34793

@ClearlyClaire ClearlyClaire marked this pull request as ready for review May 26, 2025 12:59
@ClearlyClaire ClearlyClaire requested a review from a team May 26, 2025 13:00
@ClearlyClaire
Copy link
Contributor Author

I decided to explicitly test for CDN_HOST just in case, but otherwise this is pretty much what the built-in filesystem strategy does. I have verified that it works correctly when CDN_HOST is set.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue May 26, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 26, 2025
@ClearlyClaire
Fix premailer strategy when using CDN_HOST (#34813)
d6fcc49
Merged via the queue into main with commit 955e75e May 26, 2025
33 of 34 checks passed
@ClearlyClaire ClearlyClaire deleted the fixes/premailer branch May 26, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oneiros oneiros oneiros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't send e-mail via SMTP with assets CDN enabled
2 participants
@ClearlyClaire @oneiros