Skip to content

Conversation

tribela
Copy link
Contributor

@tribela tribela commented Dec 11, 2024

This pr fixes this error:

undefined method `abs' for nil (NoMethodError) @width, @height = @height, @width if video_stream[:side_data_list]&.any? { |x| x[:rotation].abs == 90 }

@tribela
Copy link
Contributor Author

tribela commented Dec 11, 2024

By the way, Couldn't be 270 rather than -90?
Edit: I checked that rotating 270 deg also has 90 as rotation value

@Gargron Gargron added this pull request to the merge queue Dec 11, 2024
Merged via the queue into mastodon:main with commit 9ba4c8e Dec 11, 2024
27 checks passed
@tribela tribela deleted the fix-video-metadata branch December 11, 2024 04:56
vmstan pushed a commit to vmstan/mastodon that referenced this pull request Mar 27, 2025
cbl added a commit to cbl/mastodon that referenced this pull request Jul 4, 2025
* Change activity distribution error handling to skip retrying for deleted accounts (mastodon#33617)

* Fix sign-up e-mail confirmation page reloading on error or redirect (mastodon#34548)

* Fix incorrect redirect in response to unauthenticated API requests in limited federation mode (mastodon#34549)

* Add built-in context for interaction policies (mastodon#34574)

* Remove double-query for signed query strings (mastodon#34610)

* Add warning for REDIS_NAMESPACE deprecation at startup (mastodon#34581)

* Merge commit from fork

* Check scheme in account and post links

* Harden media attachments

* Client-side mitigation

* Client-side mitigation for media attachments

* Update dependency nokogiri

* Update dependency net-imap

* Bump version to v4.3.8

* Fix code style issue

* Add tests for featured tag removal (mastodon#34888)

* New Crowdin Translations for stable-4.3 (automated) (mastodon#35243)

Co-authored-by: GitHub Actions <noreply@github.com>

* Add missing autofocus on boost modal (mastodon#32953)

* Fix wrong video dimensions for some rotated videos (mastodon#33008)

* Handle rotation is not present in the video metadata (mastodon#33261)

* Fix `/share` not using server-set characters limit (mastodon#33459)

* fix: OIDC account creation fails for long display names (mastodon#34639)

* Fix admin dashboard crash on specific Elasticsearch connection errors (mastodon#34683)

* Change passthrough video processing to emit `moov` atom at start of video (mastodon#34726)

* Fix handling of inlined `featured` collections in ActivityPub actor objects (mastodon#34789)

* Fix `NoMethodError` in `ActivityPub::FetchFeaturedCollectionService` (mastodon#34811)

* Increase capybara default timeout to reduce test flakiness (mastodon#34859)

* Fix inconsistent filtering of silenced accounts for other silenced accounts (mastodon#34863)

* Fix blocked accounts not being automatically removed from trending statuses (mastodon#34891)

* Add basic support for remote attachments with multiple media types (mastodon#34996)

* Fix “Alt text” button submitting form in moderation interface (mastodon#35147)

* Fix search operators sometimes getting lost (mastodon#35190)

* Fix error when viewing statuses to deleted replies in moderation view (mastodon#32986)

* Fix `NoMethodError` in edge case of emoji cache handling (mastodon#34749)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Bump version to v4.3.9

---------

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Jeong Arm <kjwonmail@gmail.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Jeremy Kescher <jeremy@kescher.at>
Co-authored-by: Marcel Hellkamp <marc@gsites.de>
Co-authored-by: Darius Kazemi <darius.kazemi@gmail.com>
cbl added a commit to cbl/mastodon that referenced this pull request Jul 8, 2025
* Change activity distribution error handling to skip retrying for deleted accounts (mastodon#33617)

* Fix sign-up e-mail confirmation page reloading on error or redirect (mastodon#34548)

* Fix incorrect redirect in response to unauthenticated API requests in limited federation mode (mastodon#34549)

* Add built-in context for interaction policies (mastodon#34574)

* Remove double-query for signed query strings (mastodon#34610)

* Add warning for REDIS_NAMESPACE deprecation at startup (mastodon#34581)

* Merge commit from fork

* Check scheme in account and post links

* Harden media attachments

* Client-side mitigation

* Client-side mitigation for media attachments

* Update dependency nokogiri

* Update dependency net-imap

* Bump version to v4.3.8

* Fix code style issue

* Add tests for featured tag removal (mastodon#34888)

* New Crowdin Translations for stable-4.3 (automated) (mastodon#35243)

Co-authored-by: GitHub Actions <noreply@github.com>

* Add missing autofocus on boost modal (mastodon#32953)

* Fix wrong video dimensions for some rotated videos (mastodon#33008)

* Handle rotation is not present in the video metadata (mastodon#33261)

* Fix `/share` not using server-set characters limit (mastodon#33459)

* fix: OIDC account creation fails for long display names (mastodon#34639)

* Fix admin dashboard crash on specific Elasticsearch connection errors (mastodon#34683)

* Change passthrough video processing to emit `moov` atom at start of video (mastodon#34726)

* Fix handling of inlined `featured` collections in ActivityPub actor objects (mastodon#34789)

* Fix `NoMethodError` in `ActivityPub::FetchFeaturedCollectionService` (mastodon#34811)

* Increase capybara default timeout to reduce test flakiness (mastodon#34859)

* Fix inconsistent filtering of silenced accounts for other silenced accounts (mastodon#34863)

* Fix blocked accounts not being automatically removed from trending statuses (mastodon#34891)

* Add basic support for remote attachments with multiple media types (mastodon#34996)

* Fix “Alt text” button submitting form in moderation interface (mastodon#35147)

* Fix search operators sometimes getting lost (mastodon#35190)

* Fix error when viewing statuses to deleted replies in moderation view (mastodon#32986)

* Fix `NoMethodError` in edge case of emoji cache handling (mastodon#34749)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Bump version to v4.3.9

---------

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Jeong Arm <kjwonmail@gmail.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Jeremy Kescher <jeremy@kescher.at>
Co-authored-by: Marcel Hellkamp <marc@gsites.de>
Co-authored-by: Darius Kazemi <darius.kazemi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants