Change language detection debouncing behavior to refresh at least once every 1.5 seconds #33770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e every 1.5 seconds
Gargron
approved these changes
Jan 29, 2025
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Mar 27, 2025
…e every 1.5 seconds (mastodon#33770)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indeed, in the current behavior, if the user takes less than half a second between each keystroke, the language detection will only kick in half a second after they are done typing.
For quick typers who use ctrl+enter to send posts, this means they may not be notified of incorrect language.
This PR adds
maxWait: 1500so that the language detection kicks in regularly even if the user types fast.