Skip to content

Fix missing timeout options in Request class #33769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix missing timeout options in Request class #33769

merged 1 commit into from
Jan 29, 2025

Conversation

ClearlyClaire
Copy link
Contributor

Fixes #33764

In the refactor made in #33757, I failed to carry over the timeout options, causing improper timeout handling.

@ClearlyClaire ClearlyClaire added bug Something isn't working to backport PR needed to be backported build-image Build a container image for this PR labels Jan 29, 2025
@ClearlyClaire ClearlyClaire requested a review from a team January 29, 2025 08:26
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit bd48120 Jan 29, 2025
38 checks passed
@ClearlyClaire ClearlyClaire deleted the fixes/requests-timeout branch January 29, 2025 08:52
ClearlyClaire added a commit that referenced this pull request Feb 12, 2025
@ClearlyClaire
Fix missing timeout options in Request class (#33769)
07c310b
ClearlyClaire added a commit that referenced this pull request Feb 14, 2025
@ClearlyClaire
Fix missing timeout options in Request class (#33769)
7de28c0
@ClearlyClaire ClearlyClaire mentioned this pull request Feb 14, 2025
Merged
ClearlyClaire added a commit that referenced this pull request Feb 14, 2025
@ClearlyClaire
Fix missing timeout options in Request class (#33769)
8f83e7f
ClearlyClaire added a commit that referenced this pull request Feb 25, 2025
@ClearlyClaire
Fix missing timeout options in Request class (#33769)
6e90688
ClearlyClaire added a commit that referenced this pull request Feb 25, 2025
@ClearlyClaire
Fix missing timeout options in Request class (#33769)
b9f10c7
ClearlyClaire added a commit that referenced this pull request Feb 25, 2025
@ClearlyClaire
Fix missing timeout options in Request class (#33769)
b6d3510
ttrace pushed a commit to ttrace/mastodon that referenced this pull request Feb 28, 2025
@ClearlyClaire @ttrace
Fix missing timeout options in Request class (mastodon#33769)
a68bc21
@ClearlyClaire ClearlyClaire removed the to backport PR needed to be backported label Feb 28, 2025
robin-maki pushed a commit to byulmaru/mastodon that referenced this pull request Mar 1, 2025
@ClearlyClaire @robin-maki
Fix missing timeout options in Request class (mastodon#33769)
d572d2d
vmstan pushed a commit to vmstan/mastodon that referenced this pull request Mar 27, 2025
@ClearlyClaire @vmstan
Fix missing timeout options in Request class (mastodon#33769)
3a60bec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oneiros oneiros oneiros approved these changes

Assignees
No one assigned
Labels
bug Something isn't working build-image Build a container image for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LinkCrawlWorker jobs stall leading to Sidekiq queue exhaustion
2 participants
@ClearlyClaire @oneiros