Collect errors in setup rake task #33603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
previously approved these changes
Jan 16, 2025
03ee2d7 to
62fce67
Compare
ClearlyClaire
approved these changes
Jan 16, 2025
ClearlyClaire
pushed a commit
that referenced
this pull request
Feb 12, 2025
ClearlyClaire
pushed a commit
that referenced
this pull request
Feb 25, 2025
ttrace
pushed a commit
to ttrace/mastodon
that referenced
this pull request
Feb 28, 2025
robin-maki
pushed a commit
to byulmaru/mastodon
that referenced
this pull request
Mar 1, 2025
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just tracking true/false on whether we've had an error, collect them as we go and then summarize at the end.
Example output:
Ran this a few times with various scenarios and seems to do what I want.
Separately - this method is truly enormous and unwieldy. I'd like to refactor this a bit, but it's challenging to find something which would be meaningfully better but not create a pretty crazy diff.
I think if we pull out the prompt, env, errors - we might be able at minimum to make this look sort of like the CLI maintenance task does, with one private method per "section" of the setup.
Also separately - I suspect that the "does the db connection work" check is ... not actually checking. I think the method it uses changed to not raise, so it just always says its good now even with garbage values. May try to improve that as followup here.