Skip to content

Conversation

vmstan
Copy link
Contributor

@vmstan vmstan commented Sep 26, 2024

Adds the ability to opt-out of the styled scrollbars that are present in Safari and Chrome on desktop since #31445

image

The current styling should have no impact on Firefox desktop or mobile as-is, they use a different styling that is system generated with defined colors.

When opting out of the styling, Chrome will render based on platform/OS system settings, Safari should render a throbber based on macOS settings.

@vmstan vmstan changed the title Provide option to use system scrollbar styling on supported browsers Provide option to force use of system scrollbar styling Sep 26, 2024
@vmstan
Copy link
Contributor Author

vmstan commented Sep 27, 2024

Reworded both the font and scrollbar options for brevity/consistency.

ClearlyClaire
ClearlyClaire previously approved these changes Oct 4, 2024
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should this also apply to Firefox?

Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Contributor

This pull request has resolved merge conflicts and is ready for review.

@mjankowski
Copy link
Contributor

Seems like adding this as a user option should be sort of a last resort to resolving some other way?

@vmstan
Copy link
Contributor Author

vmstan commented Nov 20, 2024

I consider it similar reasoning to the system font option.

@mjankowski
Copy link
Contributor

I consider it similar reasoning to the system font option.

Could it literally be that option? "Use system stuff"? That's probably a bad idea ... just hesistant to add more combinations of options.

@renchap
Copy link
Member

renchap commented Nov 22, 2024

We haven't got negative feedback about the new scrollbars since the 4.3 final release, is this still a complaint users have?

@ClearlyClaire
Copy link
Contributor

We haven't got negative feedback about the new scrollbars since the 4.3 final release, is this still a complaint users have?

Well, #33022

@mjankowski mjankowski added ui Front-end, design area/web interface Related to the Mastodon web interface labels Nov 30, 2024
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Dec 3, 2024
Merged via the queue into mastodon:main with commit 04b7046 Dec 3, 2024
29 checks passed
@vmstan vmstan deleted the add-scrollbar-style-option branch December 3, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web interface Related to the Mastodon web interface ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants