-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Add year in review feature to web UI #32709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4fa6eb0
to
1d1e646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeating my concerns from #28693 as those have not changed:
I'm still not a fan of the popularity-based information, and I still have concerns regarding the performance cost of generating a large number of these reports, and regarding the fact this essentially holds (small amounts of) user metadata the user can't remove unless they outright delete their account.
I have also left a few more specific inline comments.
Otherwise, the UI looks good and the mascots are very cute!
Looks like the endpoint here is api-only, and the exposure/visibility is js-produced web-app-only? It would be delightful if some version of this could be produced at a shareable url that generated a pleasant opengraph experiençe. Separately - do those PNGs exist as SVG? |
I agree it would be nice to generate a shareable image but I don't see a way we could do it. Do you know of a way?
The art was delivered to me as a PSD file, so not vector. Why? |
Just to clarify, I did NOT mean like generate a png or poster size PDF or something ... those are doable, but probably more trouble than worth, especially in time available. I was mainly thinking of exposing a URL ( I think what's sort of enjoyable about these sorts of things from other platforms and giving people some easy path to sharing and self-commenting on their own prior year.
Some mix of smaller file size concerns, and "responsiveness" if we could find some way to make shareable page links. |
1d1e646
to
11dc46d
Compare
The graphics contain gradients so I cannot cleanly vectorize them. |
11dc46d
to
d785ad5
Compare
d785ad5
to
a596fb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My overall concerns about the feature remain, but the implementation looks correct.
I'm still worried about the performance, but as far as I can tell, this still does not add code to generate the reports other than fully manually from a Rails console, so that can still be evaluated and fixed before this goes live.
asking on behalf of the translators, can someone clarify the cryptic names for the archtypes? I deduced "cool hunter" means someone who reposts a lot, but what are the social butterfly, oracle, etc? It would help not only the translators, but also the users if there were some explanations... |
Literal translation would make no sense indeed, some guidelines for translators are needed to make their own "adaptation" of Wrapstodon using the cultural context people would be familiar with. |
Looking at the string identifiers and the code:
The translation string identifier is pretty self-explanatory for these except for the oracle. |
"That puts you in the top 1% of Mastodon users." sounds a bit misleading, shouldn't it be the instance name instead of 'Mastodon'? E.g. "That puts you in the top 1% of mastodon.social users." edit: (Claire also brought it up here #32709 (comment)) |
Question about this PR: Since (I guess?) 4.4.0 is unlikely to land before 2025, would a backport to 4.3.x / minor release with essentially just this be in the cards? I am hesitant to update to alpha / nightly. Anyways, it turned out really cute, hope it ends up being a good starting point to make next years even better <3 |
Also need explaination what "We won't tell Bernie" means |
This message is displayed when you're in "top 5%" (whatever it means) users. Try to come up with something funny, literal translation will not make any sense anyway. |
Thanks! I'll have a look and if it looks sane, do a database backup and potentially give it a try once I have a few hours over the weekend! |
For those that are interested in backporting, these are the commits that from the PRs mentioned above that can be cherry-picked: d6349c0 There's a few little conflicts that need to be resolved, and if you don't want to do that yourself I have a 100% UNMAINTAINED BRANCH OF 4.3 here. Please do not comment on this PR if there are issues with it, talk to me directly. https://github.com/xrobau/mastodon To generate the Year In Review:
Those instructions were found at https://blog.thms.uk/2024/12/how-to-run-wrapstodon - if something is not working, please check there! |
Follow-up to #28693.
Even though we were planning a more extensive recap feature we will likely not be able to deliver it in full before year's end, so this is a minimal one-screen implementation so we don't lose another year. This adds a new type of notification that opens a modal window with the summary screen.