Fix 'unknown' media attachment type rendering #32613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mastodon#32595. Essentially this code was reworked at some point and the previous else branch that caught the 'unknown' media type was removed.
renchap
approved these changes
Oct 22, 2024
renatolond
pushed a commit
to masto-donte-com-br/mastodon
that referenced
this pull request
Oct 22, 2024
renatolond
added a commit
to masto-donte-com-br/mastodon
that referenced
this pull request
Oct 31, 2024
Following the fix on mastodon#32613, this relates to mastodon#32595 and fixes the same issue in the detailed view
renatolond
added a commit
to masto-donte-com-br/mastodon
that referenced
this pull request
Oct 31, 2024
Following the fix on mastodon#32613, this relates to mastodon#32595 and fixes the same issue in the detailed view
ClearlyClaire
pushed a commit
that referenced
this pull request
Nov 19, 2024
ClearlyClaire
pushed a commit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32595. Essentially this code was reworked at some point and the previous else branch that caught the 'unknown' media type was removed.
@renchap @ClearlyClaire this is an active regression between v4.3.0-beta.2 and v4.3.0 / v4.3.1, where media from server's marked as "reject_media" wouldn't be displayed at all in any way.