Feat: Implement interaction modal for Polls #32609
Conversation
|
n.b., I'm not totally sold on the interaction's description, but that's something we can iterate on. |
|
Just to give you a heads up, we’re planning to rearrange this modal to make it easier for people to get at a glance. This is a useful addition, though, and we’ll let you know when those designs are ready to go so updates (if any) can be made 👍 |
|
My extremely early first draft of what this’ll look like is But, again, I have to make mockups, experiment, and iterate things before locking it in. Just didn’t want to leave you hanging in case this winds up in purgatory for a little while. |
|
@samhenrigold nice, but could this land before the redesign? also, you could do "home server or username", and then do an account search to allow them to pick which server to go to based on accounts with their username/acct |
I have no idea how long the redesign is gonna take, it depends largely on how much other work (I have three other clients in addition to Mastodon) I have to cover. I would like to have at least a design done this week or next before I have to bunker down and work on quote posts for the foreseeable future.
like an auto-complete pattern? |
Yeah, so I'm not sure why we'd block a first pass at implementing this on completely redesigning the modal — we still need to trigger it & have it do something with the right contextual information
Yeah, sometimes like that. Current we auto-complete from known domains, if you start with @ then we could auto complete from known user accounts? |
|
Let's merge this without the redesign, it can be done at a later step. Can you remove the "and have your say" part? |
|
@renchap done! (If need be, can the team update the branch? I only have my phone whilst I'm in hospital) |
* Use `likes` and `shares` totalItems on status creations and updates (mastodon#32620) * Enhance coverage for `StatusPin` model (mastodon#32515) * Update rails to version 7.1.4.2 (mastodon#32670) * Update dependency react-select to v5.8.2 (mastodon#32661) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update DefinitelyTyped types (non-major) (mastodon#32674) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @formatjs/cli to v6.3.5 (mastodon#32675) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * New Crowdin Translations (automated) (mastodon#32589) Co-authored-by: GitHub Actions <noreply@github.com> * Feat: Implement interaction modal for Polls (mastodon#32609) * Fix and improve batch attachment deletion handling when using OpenStack Swift (mastodon#32637) * Mailer header partial access cleanup (mastodon#32585) * Update babel monorepo to v7.26.0 (mastodon#32659) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Misc gem version bumps (mastodon#32684) * Use nil for timestamp column in admin/confirmations spec (mastodon#32682) * Add test coverage for POST /api/v2/media's max description length (mastodon#32683) * New Crowdin Translations (automated) (mastodon#32687) Co-authored-by: GitHub Actions <noreply@github.com> * Add telemetry for status / bio formatting (mastodon#32677) * Update dependency fog-core to '<= 2.6.0' (mastodon#32660) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Embed modal mobile fix (mastodon#32641) * Add `DomainHelpers` spec support module for DNS/MX stub (mastodon#32690) * Add coverage for `StatusTrend` and `PreviewCardTrend` models, add `locales` class method to `RankedTrend` (mastodon#32688) * Fix preview cards with long titles erroneously causing layout changes (mastodon#32678) * Update dependency libvips to v8.16.0 (mastodon#32679) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update workbox monorepo to v7.3.0 (mastodon#32691) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * New Crowdin Translations (automated) (mastodon#32695) Co-authored-by: GitHub Actions <noreply@github.com> * Add userinfo oauth endpoint (mastodon#32548) * Fix 'unknown' media attachment rendering in detailed view (mastodon#32713) * Fix IDs not being serialized as strings in annual reports API (mastodon#32710) * New Crowdin Translations (automated) (mastodon#32708) Co-authored-by: GitHub Actions <noreply@github.com> * Update dependency strong_migrations to v2.0.2 (mastodon#32705) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency selenium-webdriver to v4.26.0 (mastodon#32698) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency core-js to v3.39.0 (mastodon#32707) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency node to v22 (mastodon#32689) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Migrate from the deprecated `azure-storage-blob` to `azure-blob` (mastodon#32080) Co-authored-by: Renaud Chaput <renchap@gmail.com> * Add model spec for `Tombstone` (mastodon#32697) * Drop support for ruby 3.1 (mastodon#32363) * Update `rails-i18n` to version 7.0.10 (mastodon#32719) * Update `zeitwerk` to version 2.7.1 (mastodon#32723) * [Glitch] Feat: Implement interaction modal for Polls Port dc0b194 to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com> * [Glitch] Embed modal mobile fix Port de1d8dc Signed-off-by: Claire <claire.github-309c@sitedethib.com> * [Glitch] Fix preview cards with long titles erroneously causing layout changes Port 742eb54 to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com> * [Glitch] Fix 'unknown' media attachment rendering in detailed view Port 01e25af to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com> * Fix ruby linting issue --------- Signed-off-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Jonny Saunders <sneakers-the-rat@protonmail.com> Co-authored-by: Matt Jankowski <matt@jankowski.online> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com> Co-authored-by: Hugo Gameiro <email@hugogameiro.com> Co-authored-by: David Roetzel <david@roetzel.de> Co-authored-by: Nathan Sparrow <24910097+DismalShadowX@users.noreply.github.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Renato "Lond" Cerqueira <renato@lond.com.br> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Joé Dupuis <1518299+JoeDupuis@users.noreply.github.com> Co-authored-by: Renaud Chaput <renchap@gmail.com>
This implements the interaction modal for Polls, per #32445.
The approach I've taken here may not be the best with tunneling the
statusobject down to the poll, however, current the Poll component is connected, which handles the voting action itself, where as elsewhere we're already have the status as a prop (i.e., StatusActionBar)I've tried to go for the most minimal changes required to ship this as a feature.