Change notification request acceptance to immediately delete the request #31256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
reviewed
Aug 1, 2024
d21044a to
ab7344f
Compare
ab7344f to
65ff208
Compare
renchap
approved these changes
Aug 13, 2024
justinwritescode
pushed a commit
to justinwritescode/mastodon
that referenced
this pull request
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choosing to dismiss a notification request synchronously deletes the record, but accepting waits for the notifications to be (asynchronously) merged back into the timeline for it to be deleted, which can result in a really confusing experience.
That being said, there is a broader issue with how accepted notification requests get merged, as this happens asynchronously and is not reflected into the interface unless the notifications feed is reloaded.
(This is still a draft because the whole worker lacks tests)