Increase maximum page size for Admin Domain Management APIs #31253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
approved these changes
Aug 2, 2024
justinwritescode
pushed a commit
to justinwritescode/mastodon
that referenced
this pull request
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my experience working on FediCheck, I noticed that we were frequently needing to make at least 4-10 API requests to retrieve back the full set of domain blocks for an instance through the admin APIs, when we can just request back the full set via the public domain blocks API.
This change allows for requesting up to 500 records at a time, as opposed to 200 at a time.
From a sampling of 38 Fediverse servers that I have data for, both big and small, the median number of domain blocks is 363, with some outliers both at the low end <100 and some at the high end >1000. Given this data, 500 generally allows requesting back the full set of domain blocks in a single request, with some servers needing a few more requests.
This change will make it easier to synchronise domain block data with external tools.