Add support for PKCE Extension in OmniAuth OIDC #31131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only a binary option, since there's only two code_challenge_methods, and plain should not be used, and OmniAuth uses S256 by default
oneiros
approved these changes
Jul 25, 2024
|
@oneiros any thoughts on how we could add test coverage to SSO? I don't think it's currently covered at all really. |
|
I need to rebase this branch (but it doesn't appear to have conflicts), docs are probably blocked on mastodon/documentation#1301 |
ClearlyClaire
approved these changes
Aug 12, 2024
19 tasks
justinwritescode
pushed a commit
to justinwritescode/mastodon
that referenced
this pull request
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new optional environment variable of
OIDC_USE_PKCEwhose value must be"true"for PKCE to be enabled.Since there's only two code_challenge_methods, and plain should not be used, and OmniAuth uses S256 by default, we only support enabling or disabling PKCE. It is disabled by default.
This was requested by @erlend-sh by accident on #30329 where he thought that pull request affected SSO, when it actually only affected our OAuth setup for API access. (at least, I think that's what happened, correct me if I'm wrong).