Skip to content

Autofocus primary button in modals #31883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2024
Merged

Autofocus primary button in modals #31883

merged 1 commit into from
Sep 12, 2024

Conversation

ClearlyClaire
Copy link
Contributor

Fixes #31880

We used to autofocus the primary button in modals, but that changed with #29576.

As far as I can gather, focusing the primary button of a modal is good practice, but that may not be completely clear cut.

@ClearlyClaire
Copy link
Contributor Author

ClearlyClaire commented Sep 12, 2024 •
edited
Loading

This triggers jsx-a11y/no-autofocus on the Typescript file, but that rule is disabled in .eslintrc.js for JSX files. I'm not too sure why different rules are applied for Typescript.

EDIT: tt turns out the .eslintrc.js file re-imports plugin:jsx-a11y/recommended in an override for Typescript files. I decided to be explicit about the exception in the file itself rather than disabling the rule globally.

@ClearlyClaire ClearlyClaire added the area/web interface Related to the Mastodon web interface label Sep 12, 2024
@ClearlyClaire ClearlyClaire requested a review from a team September 12, 2024 13:06
@ClearlyClaire ClearlyClaire marked this pull request as ready for review September 12, 2024 13:06
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 5f782f9 Sep 12, 2024
34 checks passed
@ClearlyClaire ClearlyClaire deleted the fixes/modal-autofocus branch September 12, 2024 13:25
justinwritescode pushed a commit to justinwritescode/mastodon that referenced this pull request Sep 15, 2024
@ClearlyClaire
Autofocus primary button in modals (mastodon#31883)
356b60c
@ClearlyClaire ClearlyClaire mentioned this pull request Sep 17, 2024
Merged
nileane pushed a commit to nileane/mastodon that referenced this pull request Sep 17, 2024
@ClearlyClaire @nileane
Autofocus primary button in modals (mastodon#31883)
9005c58
@tribela tribela mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oneiros oneiros oneiros approved these changes

Assignees
No one assigned
Labels
area/web interface Related to the Mastodon web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default focus on modal dialogs
2 participants
@ClearlyClaire @oneiros