Change Account::Field parsing to use HTML5::DocumentFragment #31813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because we're parsing a fragment and not an HTML document
Gargron
approved these changes
Sep 8, 2024
28 tasks
|
The failing test doesn't seem related to this change. Could be a flake? |
justinwritescode
pushed a commit
to justinwritescode/mastodon
that referenced
this pull request
Sep 15, 2024
nileane
pushed a commit
to nileane/mastodon
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is one in a series that aims to update Mastodon to parse all HTML content as HTML5. See #31812 for a longer explanation.
Changes
Change
Nokogiri::HTMLtoNokogiri::HTML5.fragmentbecause we're parsing a fragment and not an HTML document. Also change the guard clause to check for children size != 1 because the nodeset may be empty.