Skip to content

Conversation

fowl2
Copy link
Contributor

@fowl2 fowl2 commented Sep 1, 2024

eg. allowing /oauth/authorized_applications#436138 to scroll to the right place.

Future work might be:

  • to highlight the linked to app
  • a page for each app, as authorized_applications/:id currently 404s (try middling clicking "revoke")

Co-authored-by: Matt Jankowski <matt@jankowski.online>
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although I'm not too sure of the use case.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Sep 5, 2024
Merged via the queue into mastodon:main with commit f9712fa Sep 5, 2024
27 checks passed
justinwritescode pushed a commit to justinwritescode/mastodon that referenced this pull request Sep 15, 2024
@ThisIsMissEm
Copy link
Contributor

@fowl2 for highlighting, you could use the :target selector in CSS, which would apply if the element is the ID that's in the URL fragment.

@ThisIsMissEm
Copy link
Contributor

ThisIsMissEm commented Sep 17, 2024

a page for each app, as authorized_applications/:id currently 404s (try middling clicking "revoke")

This also sounds like a decent idea, though would be custom as doorkeeper doesn't support that out of the box, afaik

nileane pushed a commit to nileane/mastodon that referenced this pull request Sep 17, 2024
@fowl2 fowl2 deleted the patch-2 branch September 18, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants