-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Add timeline of public posts about a trending link to REST API #30381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Might fix #19620 too? |
I figure that issue can't be closed until there's UI for it too. For now, this PR is API only. |
1f7b6a7
to
fb9f6d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Maybe add spec for the scenario where there's not a matching preview card (and statuses are empty)?
fb9f6d8
to
be7c4b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I am a bit wary of potential abuse, but I think this is most probably curbed by the restrictions implemented in this PR, that is:
- only public posts from people having opted into discoverability features will appear here
- this is limited to currently-trending links
Adds a timeline of statuses that posted about a trending link. See mastodon/mastodon#30381 for more details.
While a link is trending, allow browsing posts that include it, as long as the authors are opted-in to being discoverable.
The endpoint is
GET /api/v1/timelines/link?url=:url
Fixes MAS-19