Skip to content

Add timeline of public posts about a trending link to REST API #30381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented May 20, 2024

While a link is trending, allow browsing posts that include it, as long as the authors are opted-in to being discoverable.

The endpoint is GET /api/v1/timelines/link?url=:url


Fixes MAS-19

@Gargron Gargron added the api REST API, Streaming API, Web Push API label May 20, 2024
@trwnh
Copy link
Member

trwnh commented May 20, 2024

Might fix #19620 too?

@Gargron
Copy link
Member Author

Gargron commented May 20, 2024

I figure that issue can't be closed until there's UI for it too. For now, this PR is API only.

@renchap renchap requested a review from a team May 21, 2024 08:46
@Gargron Gargron force-pushed the feature-link-feed branch from 1f7b6a7 to fb9f6d8 Compare May 25, 2024 22:28
Copy link
Contributor

@mjankowski mjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Maybe add spec for the scenario where there's not a matching preview card (and statuses are empty)?

Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I am a bit wary of potential abuse, but I think this is most probably curbed by the restrictions implemented in this PR, that is:

  • only public posts from people having opted into discoverability features will appear here
  • this is limited to currently-trending links

@Gargron Gargron added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit a2505e8 Jun 6, 2024
@Gargron Gargron deleted the feature-link-feed branch June 6, 2024 08:48
FineFindus added a commit to FineFindus/moshidon that referenced this pull request Jun 15, 2024
Adds a timeline of statuses that posted about a trending link.
See mastodon/mastodon#30381 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api REST API, Streaming API, Web Push API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants