Skip to content

Change ActiveRecordEncryption variable to be more explicit #30151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2024
Merged

Change ActiveRecordEncryption variable to be more explicit #30151

merged 2 commits into from
May 3, 2024

Conversation

ClearlyClaire
Copy link
Contributor

  • change the error to mention Mastodon rather than ActiveRecord encryption, making it explicit that it is a Mastodon requirement and not something random in the stack
  • abort instead of raiseing, to avoid printing a confusing stack trace
  • override the db:encryption:init task to output something that can be copied under the right format

@ClearlyClaire ClearlyClaire requested review from mjankowski and a team May 2, 2024 15:20
mjankowski
mjankowski reviewed May 2, 2024
View reviewed changes
ThisIsMissEm
ThisIsMissEm reviewed May 2, 2024
View reviewed changes
mjankowski
mjankowski approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@mjankowski mjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor naming comment about what to call the task, but overall the changes are a good improvement for communicating how to add this.

@ClearlyClaire ClearlyClaire enabled auto-merge May 3, 2024 08:28
@ClearlyClaire ClearlyClaire added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 33368e3 May 3, 2024
@ClearlyClaire ClearlyClaire deleted the fixes/active_record_encryption_variables branch May 3, 2024 09:27
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request May 20, 2024
@ClearlyClaire @Ember-ruby
Change ActiveRecordEncryption variable to be more explicit (mastodon#…
8fa6a33 
…30151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renchap renchap renchap approved these changes

+2 more reviewers

@ThisIsMissEm ThisIsMissEm ThisIsMissEm left review comments

@mjankowski mjankowski mjankowski approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ClearlyClaire @mjankowski @ThisIsMissEm @renchap