Improve handling of libvips failures #30597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
reviewed
Jun 7, 2024
There was a problem hiding this comment.
If imagemagick/vips are going to co-exist for a while, I could see a refactor here where we bundle up all the paperclip/vips/imagemagick/etc error classes into like a Mastodon::MEDIA_PROCESSING_ERRORS (or something) constant and adjust the handling to use that ... which would make the eventual future removal of imagemagick (and maybe someday paperclip!) more straightforward with that in place in advance.
All that said, for right now while we are still in "introducing vips" stage, this looks good.
renchap
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat libvips failures as paperclip failures so that they are caught and handled like other media processing failures.