Drop compatibility with Redis < 6.2 #30413
Conversation
|
(If #30412 gets merged, I'll keep this PR as a more long-term one for after 4.3) |
|
To be merged after 4.4. It may be a good idea to fail to start if Redis is too old? |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
Looks like this needs rebase, but also to clarify -- does "merge after 4.4" mean "merge after we've started on 4.4" (ie, now), or "merge after we RELEASE 4.4" (ie, later)? |
Still curious on this -- should this version support drop start hitting nightlies now, or waiting for after next release? |
|
Well, for a start, mastodon.social is still using Redis < 6.2 |
|
Feels like a blocker. |
2b8292a to
309d8b0
Compare
|
mastodon.online and mastodon.social are now running Redis 7.2. However, Ubuntu 22.04 LTS, which I expect is still a pretty popular distribution amongst Mastodon server administrators, only provides Redis 6.0… Also of note, sidekiq 7.x requires Redis 6.2+, and sidekiq 8.x requires Redis 7.0+ |
|
This pull request has resolved merge conflicts and is ready for review. |
|
Looks like this will be required for sidekiq 7, which we want to move to. |
|
Sort of related here ... in the aftermath of sidekiq 7 merging and rack 3 presumably merging soon, it occurs to me that we could actually go all the way to sidekiq 8 ... except that does bring a redis 7.0 requirement with it. I see that 6.2 is past EOL and am curious ... if we are comfortable doing a minimum version bump here which may require some older distro folks to do upgrades beyond stock install - could we go all the way to 7.0? Or is there a sweet spot where 6.2 is more viable for people but 7.0+ would be too far? |
|
Redis 7.0 should be available on Ubuntu 24.04 LTS as well as the latest Debian stable, so updating all the way to Redis 7.0 does not seem to be a dealbreaker, though this could still be a somewhat steep requirement. Updating to sidekiq 8 for Mastodon 4.4 seems possible, and if that fails, 4.5 would definitely be an appropriate target. |
|
Sounds good ... will open something as draft for now and we can contemplate timing. |
|
I think I would prefer have Sidekiq 7 in Mastodon 4.4, and Sidekiq 8 in Mastodon 4.5 |
Alternative to #30412
On the one hand, some major distributions, like Ubuntu 22.04 LTS, still ship earlier versions of Redis, so this may be a relatively disruptive change for many server administrators.
On the other hand, Redis versions earlier to 6.2 are not officially maintained anymore, and at least one of our dependencies (Stoplight) has silently dropped support for it, so maintaining compatibility with Redis < 6.2 is becoming harder.