Remove webauthn credentials on tootctl accounts modify --disable-2fa
#29883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New commit submitted which uses the |
mjankowski
reviewed
Nov 21, 2024
ClearlyClaire
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running
tootctl accounts modify --disable-2faon an account with webauthn devices set, 2 factor is still required for webauthn.The above command only sets
user.otp_required_for_loginto false but does not clear theuser.webauthn_credentials. And if the webauthn_credentials is not empty (if the user has setup webauthn), then 2fa is still required during login.This commit tries to fix this issue by also emptying the webauthn devices when running the above admin cli command.
Related to issue: #27502