Change design of notification about lost connections in web UI #29731
Conversation
Gargron
commented
Mar 24, 2024
|
The newer message seems more clear and easier to understand! That said, I am unsure if "An admin" could be confusing since moderators can block/suspend, too. Though I get that "a moderator" doesn't shorten down as nicely ("a mod" could sound like a browser/etc modification), and this distinction might not matter in practice. (Regardless, even as someone running a single-user instance, I am immensely happy to see the overall feature making it into v4.3.0.) |
There was a problem hiding this comment.
The wording is an improvement, and so is the overall design, but it does not really fit with our other notification designs, because of the much larger padding, the larger icon, and the fact that everything is padded right:
Shouldn't it use the same padding and icon size as the other notifications (while possibly changing all of them in a future PR)?
|
I think that the uniqueness of this notification makes it possible to have it use the new design first. As a second step I would update all other non-mention notifications to have the new design. |
| domain_block: { id: 'relationship_severance_notification.types.domain_block', defaultMessage: 'Domain has been suspended' }, | ||
| user_domain_block: { id: 'relationship_severance_notification.types.user_domain_block', defaultMessage: 'You blocked this domain' }, | ||
| account_suspension: { id: 'notification.relationships_severance_event.account_suspension', defaultMessage: 'An admin from {from} has suspended {target}, which means you can no longer receive updates from them or interact with them.' }, | ||
| domain_block: { id: 'notification.relationships_severance_event.domain_block', defaultMessage: 'An admin from {from} has blocked {target}, including {followersCount} of your followers and {followingCount, plural, one {# account} other {# accounts}} you follow.' }, |
There was a problem hiding this comment.
followersCount also needs plural forms