install "wget" in streaming Dockerfile #28497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"wget" is used by the [docker-compose health-check](https://github.com/mastodon/mastodon/blob/main/docker-compose.yml#L89) and is currently not installed. The same health check can be achieved with `curl` (which is installed), but thought simply installing wget would be sufficient and avoid breaking any existing docker-compose based servers (like my own) when they upgrade to 4.3 Happy to update to using `curl` instead if preferred
vmstan
approved these changes
Dec 26, 2023
|
Yeah that's an oversight on my part during the refactor. I would like to redo the Docker Compose to use curl but we don't need to break existing deployments 😄 |
ClearlyClaire
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"wget" is used by the docker-compose health-check and is currently not installed.
The same health check can be achieved with
curl(which is installed), but thought simply installing wget would be sufficient and avoid breaking any existing docker-compose based servers (like my own) when they upgrade to 4.3Happy to update to using
curlinstead if preferred