-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Add ability to require approval when users sign up using specific email domains #28468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0d951de
to
56abf1b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #28468 +/- ##
==========================================
+ Coverage 84.66% 84.80% +0.14%
==========================================
Files 1039 1039
Lines 28254 28287 +33
Branches 4556 4567 +11
==========================================
+ Hits 23922 23990 +68
+ Misses 3179 3139 -40
- Partials 1153 1158 +5 ☔ View full report in Codecov by Sentry. |
55ee8d9
to
8631dab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but maybe we should add some specs to ensure that signing up with a domain requiring approval does the correct thing?
8631dab
to
3606cbc
Compare
Added some more tests! |
…uiring approval Follow-up to #28468
…uiring approval Follow-up to #28468
This PR allows adding relaxed email domain blocks which allow people to register but requiring approval.
Fixes MAS-210