Skip to content

Change rate limits to 1,500/5m per user, 300/5m per app #23347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Feb 1, 2023

No description provided.

@ClearlyClaire
Copy link
Contributor

I'm afraid this would let bad actors easily bypass limits by just multiplying app registrations

@trwnh
Copy link
Member

trwnh commented Feb 1, 2023

bypass limits by just multiplying app registrations

isn't that the point of the per-user limit? the math works out so that it assumes each user may use 5 clients

@Gargron Gargron merged commit c6ef56f into main Feb 1, 2023
@Gargron Gargron deleted the fix-rate-limit-per-token branch February 1, 2023 23:08
@lapineige
Copy link

Does this affect removals too ?

@ClearlyClaire
Copy link
Contributor

isn't that the point of the per-user limit? the math works out so that it assumes each user may use 5 clients

Yes, you're right, I somehow missed that block 🤦‍♀️

Does this affect removals too ?

Yes and now, deletes fall into these limits but they also have their own separate limit which is unchanged.

@lapineige
Copy link

So if I understand it correctly that won't change the maximum deletion rate ? :(
But that would allow to delete up to the quota and still use the account as usual without reaching the limit, right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants