Skip to content

chore: refactor #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 28, 2025
Merged

chore: refactor #20

merged 9 commits into from
Mar 28, 2025

Conversation

ldez
Copy link
Collaborator

@ldez ldez commented Mar 28, 2025 •
edited
Loading

  • Rename options
  • Use diagnostic instead of error
  • improve readability
  • simplify tests

manuelarte
manuelarte approved these changes Mar 28, 2025
View reviewed changes
Copy link
Owner

@manuelarte manuelarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only say 👏

@manuelarte
Copy link
Owner

approved

@manuelarte manuelarte merged commit 6b37c37 into manuelarte:main Mar 28, 2025
9 checks passed
@ldez ldez deleted the feat/refactor branch March 28, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelarte manuelarte manuelarte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @manuelarte