[@mantine/core] Table: Fix missing border when rowspan is present #8137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for creating this PR. I initially wanted to provide a solution myself, but failed to do so because of limited time. |
|
Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
withColumnBordersalong with rowSpan cells, some borders do not appear (#8088).Why
Table styles define that borders are given at the end pof each cell that is not last child. The issue is that when rowspan is used, even it seems like a cell is not the last one, for the DOM it is.
Solution
In order to fix this via CSS I decided to add another rule that places a border at the start of every cell if it is not the first one. This fixes the cases where rowspan is used.
I choose this solution as I did not found any other way to fix this without requiring the developer to provide manually a "lastCell" indicator.