Add onOverflowChange callback to ScrollArea.Autosize
#7972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtivital
requested changes
Jul 7, 2025
|
|
||
| useEffect(() => { | ||
| const el = viewportObserverRef.current; | ||
| if (!el) { |
There was a problem hiding this comment.
This logic might have a significant impact on performance, add early return if onOverflowChange is not a function
There was a problem hiding this comment.
Done, I also refactored it to use the useResizeObserver hook.
rtivital
requested changes
Jul 9, 2025
|
|
||
| // Overflow detection (Autosize-only) | ||
| const [resizeObserverRef, rect] = useResizeObserver<HTMLDivElement>(); | ||
| const combinedViewportRef = useMergeRefs([viewportRef, resizeObserverRef]); |
There was a problem hiding this comment.
Not a good solution: adds significant overhead with resize observer tracking when onOverflowChange is not passed. ResizeObserver must only listen for changes when it is required.
There was a problem hiding this comment.
Good point - I reverted the last two commits and added the early return guard.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
onOverflowChange?: (overflowing: boolean) => voidprop to ScrollArea.Autosize.It fires when content starts or stops exceeding max-height, enabling consumers to react when the container becomes scrollable.
95208be5a7182e7515d9a6eca68051df.mp4