feat(DatePicker): Add keyboard shortcuts for year navigation accessib… #7959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility This PR improves DatePicker accessibility by adding keyboard shortcuts for year navigation, addressing the need for better keyboard support when selecting dates far in the past (like birth dates). New keyboard shortcuts: - Ctrl/Cmd + Arrow Up/Down: Navigate by year - Ctrl/Cmd + Shift + Arrow Up/Down: Navigate by decade - Y key: Open year selection view Changes: - Added enableKeyboardNavigation prop to Calendar component (enabled by default) - Implemented keyboard event handlers for year/decade navigation - Added comprehensive test coverage for keyboard navigation - Created demo showcasing the new feature - Added documentation for keyboard shortcuts Fixes mantinedev#5444 and partially addresses mantinedev#332
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the DatePicker’s accessibility by adding keyboard shortcuts for year and decade navigation. The changes include updated prop definitions for keyboard navigation support, new event handlers in the Calendar component, demo updates, and accompanying documentation.
- Added enableKeyboardNavigation prop to propagate keyboard navigation functionality from DatePicker to Calendar.
- Implemented keyboard event handling for year and decade navigation including a key-based shortcut for opening the year view.
- Updated demo and documentation files to showcase and explain the new keyboard shortcuts.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/@mantine/dates/src/components/DatePicker/DatePicker.tsx | Updated prop types to include keyboard navigation options from CalendarProps. |
| packages/@mantine/dates/src/components/Calendar/Calendar.tsx | Added keyboard event handling via useEffect and updated default props. |
| packages/@docs/demos/src/demos/dates/DatePicker/index.ts | Exported new keyboardNavigation demo. |
| packages/@docs/demos/src/demos/dates/DatePicker/DatePicker.demo.keyboardNavigation.tsx | Created demo showcasing keyboard navigation usage. |
| docs/keyboard-navigation.md | Added documentation for the new keyboard shortcut features. |
Comments suppressed due to low confidence (1)
packages/@mantine/dates/src/components/Calendar/Calendar.tsx:397
- The dependency array for the keyboard navigation effect includes several callback functions (e.g., handleNextYear, handlePreviousYear, etc.). Consider memoizing these functions with useCallback to avoid unnecessary re-renders and repeated event listener registrations.
],
rtivital
requested changes
Jul 7, 2025
packages/@docs/demos/src/demos/dates/DatePicker/DatePicker.demo.keyboardNavigation.tsx
Outdated
Show resolved
Hide resolved
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves DatePicker accessibility by adding keyboard shortcuts for year navigation, addressing the need for better keyboard support when
selecting dates far in the past (like birth dates).
New keyboard shortcuts:
Changes:
Fixes #5444 and partially addresses #332