fix build issues discovered during and after v9.2.0 release #2684
Conversation
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
There was a problem hiding this comment.
Hello @mike-hunhoff, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team,
Gemini or gemini-code-assist here to provide a summary of this pull request. This PR, authored by @mike-hunhoff, aims to fix build issues that were discovered during and after the v9.2.0 release. Specifically, it addresses problems encountered during the PyInstaller build process, as indicated by the linked issues #2683 and #2681. The primary change involves adjusting the PyInstaller specification file to ensure necessary modules are included.
Highlights
- PyInstaller Build Fix: This pull request includes a change to the PyInstaller specification file (
.github/pyinstaller/pyinstaller.spec) to address a build issue. It addspkg_resourcesto thehiddenimportslist (lines 77-79 in the modified file). This is noted in the code as a temporary workaround until issue #2681, related to PyInstaller's handling of this module, is resolved.
Changelog
- .github/pyinstaller/pyinstaller.spec
- Added
pkg_resourcesto thehiddenimportslist (lines 77-79) as a temporary fix for a PyInstaller build issue (closes #2681).
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request addresses build issues discovered during and after the v9.2.0 release. The changes involve adding pkg_resources to the Analysis in the pyinstaller.spec file. This seems to be a workaround for an issue with PyInstaller. Overall, the change is small and targeted.
Summary of Findings
- Missing context for workaround: The comment indicates a temporary workaround, but lacks a link to the tracked PyInstaller issue or a brief explanation of the problem being solved.
Merge Readiness
The pull request addresses a specific build issue and includes a temporary workaround. While the change is small and targeted, adding more context to the comment would improve maintainability. I am unable to approve this pull request, and recommend that others review and approve this code before merging. I recommend addressing the medium severity issues before merging.
CHANGELOG updated or no update needed, thanks! 😄
closes #2683 , #2681, #2682
Checklist