Skip to content

cape: models: parse minimum fields required for analysis #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

mike-hunhoff
Copy link
Collaborator

@mike-hunhoff mike-hunhoff commented Feb 18, 2025

Only parse the CAPE fields required for analysis and ignore the rest. This drastically reduces the bug surface and number of CAPE models that we must maintain to avoid pydantic errors (e.g. #2539). Fields that were never used have been commented out (to remain as documentation) and we can add fields back in the future, as/if needed.

Fixes #2539.

@mike-hunhoff mike-hunhoff requested a review from a team February 18, 2025 21:11
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@github-actions github-actions bot dismissed their stale review February 18, 2025 21:14

CHANGELOG updated or no update needed, thanks! 😄

Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@mike-hunhoff mike-hunhoff merged commit a278bf5 into master Feb 19, 2025
28 checks passed
@mike-hunhoff mike-hunhoff deleted the fix/2539 branch February 19, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPE model errors - CapeReport.procmemory
2 participants