Skip to content

fix: escape "." in regex features that are not expected to be dot operators #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix: escape "." in regex features that are not expected to be dot operators #1028

merged 1 commit into from
Mar 18, 2025

Conversation

mike-hunhoff
Copy link
Collaborator

see #1026 for an example of how unescaped . can results in FPs.

@mike-hunhoff mike-hunhoff requested a review from a team March 18, 2025 20:18
@mike-hunhoff mike-hunhoff mentioned this pull request Mar 18, 2025
Merged
williballenthin
williballenthin approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, great!

in addition to being more specific, I think this will make the patterns slightly faster, too!

@mike-hunhoff mike-hunhoff merged commit e85887a into master Mar 18, 2025
3 checks passed
@mike-hunhoff mike-hunhoff deleted the fix/unescaped/dot branch March 18, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-hunhoff @williballenthin