Skip to content

reduce fps for self-delete.yml #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

reduce fps for self-delete.yml #985

merged 1 commit into from
Jan 29, 2025

Conversation

mike-hunhoff
Copy link
Collaborator

Removes FP regex match /del\s*\S/ for api-ms-win-appmodel-runtime-l1-1-2 discovered during testing.

Input:

del /path/to/file
del "/path/to/file"
api-ms-win-appmodel-runtime-l1-1-2
cmd.exe /c "ping 127.0.0.1 & del \"/path/to/file\""
cmd.exe /c "ping 127.0.0.1&del \"/path/to/file\""

Matches:

del /path/to/file
del "/path/to/file"
& del \"/path/to/file\""
&del \"/path/to/file\""

@mike-hunhoff mike-hunhoff requested review from williballenthin and a team January 28, 2025 20:58
@mr-tz mr-tz merged commit ff76d01 into master Jan 29, 2025
3 checks passed
@mr-tz mr-tz deleted the fix/self/delete/fp branch January 29, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike-hunhoff @williballenthin @mr-tz