Sync xcode26 changes #173
Merged
Sync xcode26 changes #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the build errors for actor isolated
The keyboard shortcut (.init(.return)) button used to be blue, but it remains unchanged in Xcode 26. Therefore, I need to make a change.
Add .buttonStyle(.borderedProminent)
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the project with the xcode26 updates by standardizing button styling and updating asynchronous handling in file selection.
- Updated multiple views with the new prominent button style (.buttonStyle(.borderedProminent)).
- Wrapped file URL processing in ContentView with a Task block to enforce main actor execution.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| GitClient/Views/StashChanged/StashChangedContentView.swift | Added prominent button styling to the stash changed view. |
| GitClient/Views/Folder/Sheets/RenameBranchSheet.swift | Added prominent button styling in the rename branch sheet. |
| GitClient/Views/Folder/Sheets/CreateNewTagSheet.swift | Added prominent button styling in the create new tag sheet. |
| GitClient/Views/Folder/Sheets/CreateNewBranchSheet.swift | Added prominent button styling in the create new branch sheet. |
| GitClient/Views/Folder/Sheets/AmendCommitSheet.swift | Added prominent button styling in the amend commit sheet. |
| GitClient/Views/ContentView.swift | Wrapped URL processing in a Task block with @mainactor to ensure UI updates. |
| GitClient/Views/Commit/CommitMessageSnippetView.swift | Added prominent button styling in the commit snippet view. |
| GitClient/Views/Commit/CommitCreateView.swift | Added prominent button styling in the commit create view. |
Comments suppressed due to low confidence (1)
GitClient/Views/ContentView.swift:70
- [nitpick] Confirm that wrapping the file URL processing in a Task with @mainactor is necessary since panel.begin's callback may already be executing on the main thread. If redundant, consider removing it to simplify the asynchronous logic.
Task { @MainActor in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.