Top toolbar #169
Merged
Top toolbar #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed old navigation toolbar implementation. - Added branches button with updated icon. - Enhanced loading state display with a progress view.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the top toolbar in FolderView by refactoring how toolbar items are conditionally rendered based on loading state and macOS version. It replaces the navigationToolbar() function with a dedicated branchesButton() and introduces macOS 26 availability checks for certain toolbar items.
- Refactored toolbar item configuration for loading and non-loading states.
- Replaced the navigationToolbar() function with a branchesButton() implementation.
- Added availability checks for macOS 26 to conditionally display progress views and spacer items.
Comments suppressed due to low confidence (1)
GitClient/Views/Folder/FolderView.swift:312
- [nitpick] Renaming navigationToolbar to branchesButton may be confusing if the function is expected to handle more than just branch selection. Ensure that the function name accurately reflects its purpose.
fileprivate func branchesButton() -> some View {
| .toolbar { | ||
| if isLoading { | ||
| ProgressView() | ||
| .scaleEffect(x: 0.5, y: 0.5, anchor: .center) | ||
| if #available(macOS 26.0, *) { |
There was a problem hiding this comment.
The progress view configuration is duplicated for macOS 26 and the alternative case. Consider extracting the common ProgressView configuration into a helper view to reduce repetition.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.