Selected color in graph view #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `@Environment` property for active appearance detection. - Updated foreground color logic based on active appearances and selection states. - Improved background color handling for selected nodes based on active status.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the color selection logic to adjust the visual appearance based on the environment’s active state. Key changes include the removal of the appearsActive injection in FolderView and modifications in CommitGraphView to conditionally define background and foreground colors.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| GitClient/Views/Folder/FolderView.swift | Removed unused @Environment injection for appearsActive |
| GitClient/Views/Folder/CommitGraphView.swift | Updated color styling logic using appearsActive in GraphNode and GraphNodeText |
| @Binding var selectionLogID: String? | ||
| @Binding var subSelectionLogID: String? | ||
| @Environment(\.appearsActive) private var appearsActive |
There was a problem hiding this comment.
[nitpick] Consider moving the @Environment(.appearsActive) declaration above the computed property 'foregroundStyle' to improve code readability and maintain consistency in the ordering of property declarations.
Suggested change
| @Environment(\.appearsActive) private var appearsActive |
Copilot uses AI. Check for mistakes.
- Made CommitGraphView focusable and disabled focus effects to improve usability. - Updated GraphNode to change appearance based on focus state. - Refined fill colors for selected nodes based on active focus state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.