Multiple author #155
Merged
Multiple author #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the GitLog struct to replace the single author string with an array of authors. Modified argument building to handle multiple authors when generating git log commands. Additionally, updated the LogStore to reflect the changes in authors parsing.
…eferences in FolderView and related tests.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances search functionality by supporting multiple authors, refactors token handling for clarity, and updates tests and UI to match the new API.
- Introduce multi-author support in
GitLogandLogStore - Rename
SearchTokensHandler.handletonormalizeand consolidate token logic - Update tests and
FolderViewto use the newnormalizemethod
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| GitClientTests/SearchTokensHandlerTests.swift | Updated tests to call normalize instead of handle |
| GitClient/Views/Folder/FolderView.swift | Switched from handle to normalize in the search tokens update |
| GitClient/Models/SearchTokensHandler.swift | Renamed handle → normalize and merged .author with .path case |
| GitClient/Models/Observables/LogStore.swift | Changed single author property to authors array |
| GitClient/Models/Commands/GitLog.swift | Replaced single --author flag with multiple --author args |
Comments suppressed due to low confidence (2)
GitClientTests/SearchTokensHandlerTests.swift:28
- Typo in test name:
Mathshould beMatchto reflect.grepAllMatch.
@Test func handleGrepAllMath() async throws {
GitClientTests/SearchTokensHandlerTests.swift:103
- Typo in test name:
Auhorshould beAuthor.
@Test func handleAuhorInEdit() async throws {
| @@ -72,7 +63,7 @@ struct SearchTokensHandler { | |||
| return true | |||
| } | |||
| } | |||
| case .path: | |||
| case .author, .path: | |||
There was a problem hiding this comment.
The .author case was merged with .path and now always returns all tokens, which breaks the intended behavior of replacing old author tokens. Separate .author into its own case and filter only the new author tokens.
Suggested change
| case .author, .path: | |
| case .author: | |
| return newTokens.filter { token in | |
| switch token.kind { | |
| case .author: | |
| return !oldTokens.contains(token) | |
| default: | |
| return true | |
| } | |
| } | |
| case .path: |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://git-scm.com/docs/git-log#Documentation/git-log.txt---authorltpatterngt
===========
This pull request introduces changes to support multiple authors in search filters, refactors the
SearchTokensHandlerfor improved clarity, and updates related tests. The most significant changes include replacing single-author handling with multi-author support, renaming thehandlemethod tonormalizefor better semantic alignment, and modifying tests to reflect these updates.Support for multiple authors:
GitLog.swiftto replace single-author handling (author) with multi-author support (authors) and adjusted the logic for constructing Git command arguments. [1] [2]LogStore.swiftto support multiple authors in search tokens by changingauthortoauthors. [1] [2]Refactoring for clarity:
handlemethod inSearchTokensHandler.swifttonormalizefor improved semantic clarity.authortokens inSearchTokensHandler.swiftby removing redundant filtering and aligning behavior with other token types. [1] [2]Test updates:
SearchTokensHandlerTests.swiftto use the renamednormalizemethod and to reflect the changes in token handling logic.UI integration:
FolderView.swiftto use the updatednormalizemethod for handling search tokens, ensuring compatibility with the refactored logic.