No changes in commit diff #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9d495ad.
- Introduced a new state variable `filesChangesIsEmpty` to manage the display of an empty state. - Added a message indicating 'No Changes' when there are no file changes. - Updated the shortstat logic to display 'No Changes' when appropriate.
This reverts commit 5af5810.
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the user experience in the CommitDiffView by displaying a "No Changes" message when there are no file differences and simplifies the code by removing the unnecessary cached parameter from the updateDiff method.
- Added a state variable to track if there are file changes and conditionally display a "No Changes" message.
- Updated the shortstat string to display "No Changes" when empty.
- Refactored the updateDiff method to remove the redundant cached parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to the
CommitDiffViewinGitClient/Views/Commit/CommitDiffView.swiftto enhance user experience and simplify the code by removing unnecessary parameters. The key changes include adding a "No Changes" message when there are no file differences and refactoring theupdateDiffmethod to remove thecachedparameter.User Experience Improvements:
filesChangesIsEmptyto track whether there are any file changes. If no changes are detected, a "No Changes" message with aLabelis displayed in theScrollView. ([GitClient/Views/Commit/CommitDiffView.swiftR18-R33](https://github.com/maoyama/Tempo/pull/147/files#diff-51f1ff4df91dce0f310e65c2690f4fe206a33ba9f281a6d38eca08caface7cd4R18-R33))shortstatstring to display "No Changes" when it is empty, providing clearer feedback to the user. ([GitClient/Views/Commit/CommitDiffView.swiftL70-R104](https://github.com/maoyama/Tempo/pull/147/files#diff-51f1ff4df91dce0f310e65c2690f4fe206a33ba9f281a6d38eca08caface7cd4L70-R104))Code Simplifications:
cachedparameter from theupdateDiffmethod and its associated calls, simplifying the method signature and logic. ([GitClient/Views/Commit/CommitDiffView.swiftL70-R104](https://github.com/maoyama/Tempo/pull/147/files#diff-51f1ff4df91dce0f310e65c2690f4fe206a33ba9f281a6d38eca08caface7cd4L70-R104))