Fix expandable state #133
Merged
Fix expandable state #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated logic to maintain expansion state of file diffs when new data is loaded. - Modified mapping of cached and new file diffs to preserve user interactions.
- Added ExpandableModelTests to test the `withExpansionState(from:)` method in Array extension for handling expansion state. - Updated project.pbxproj to include the new test file. - Enhanced ExpandableModel struct with necessary functionality for testing.
There was a problem hiding this comment.
Pull Request Overview
The PR fixes the expandable state handling to preserve user-expansion choices when updating the list of models.
- Added tests in ExpandableModelTests to verify state preservation and default behavior.
- Updated CommitCreateView to use the withExpansionState extension when updating file diffs.
- Introduced an Array extension for merging old expansion states with new models in ExpandableModel.swift.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| GitClientTests/ExpandableModelTests.swift | New tests to verify that the expansion state is correctly preserved. |
| GitClient/Views/Commit/CommitCreateView.swift | Updated view logic to merge new file diffs with existing expansion states. |
| GitClient/Models/ExpandableModel.swift | Added an Array extension to support merging expansion states. |
Files not reviewed (1)
- GitClient.xcodeproj/project.pbxproj: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.