Skip to content

Fix commit graph rendering logic #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2025
Merged

Fix commit graph rendering logic #117

merged 2 commits into from
May 1, 2025

Conversation

maoyama
Copy link
Owner

@maoyama maoyama commented May 1, 2025

Before
Screenshot 2025-05-01 at 23 14 40
After
Screenshot 2025-05-01 at 23 13 35

@maoyama maoyama requested a review from Copilot May 1, 2025 14:22
Copilot
Copilot AI reviewed May 1, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the commit graph rendering logic to correctly handle branches by adjusting how columns are reused.

  • Modified the condition in the children iteration to remove a column from use only for commits with a single parent.
  • This change prevents premature removal of column indices when dealing with merge commits.

@maoyama
Copy link
Owner Author

maoyama commented May 1, 2025

#76

@maoyama maoyama merged commit 25d027a into main May 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maoyama