Context menu on graph #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved context menu handling from CommitLogView to a new method `commitContextMenu` in View extension. - Improved code readability and reusability by separating context menu logic.
- Added bindings for `showing` and `isRefresh` to `CommitGraphView`. - Updated `CommitGraphContentView` to accommodate new bindings and updated context menu. - Adjusted layout and preview configurations accordingly to integrate new features.
- Integrated a context menu for commits in the commit graph view, allowing users to perform actions related to the selected commit. - Passed necessary parameters such as folder, commit, logStore, isRefresh, showing, and bindingError to the context menu.
…utes - Removed commented-out preview code and replaced it with active previews - Introduced state variables for managing selection log ID, log store, visibility, and refresh status - Updated sample commits for better structure and clarity in previews - Structured previews for consistent styling and functionality across different contexts.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the context menu functionality on commits, unifying the implementation across the commit log and graph views. Key changes include:
- Adding new bindings (showing, isRefresh) to support the refactored context menus.
- Removing the redundant showGraph binding from CommitLogView.
- Extracting the common context menu logic into a new commitContextMenu extension on View.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| GitClient/Views/Folder/FolderView.swift | Updated view bindings to pass new parameters to context menu modifiers. |
| GitClient/Views/Folder/CommitLogView.swift | Removed unused showGraph binding and updated context menu usage. |
| GitClient/Views/Folder/CommitGraph.swift | Updated context menu invocations in graph view and previews. |
| GitClient/Views/Extensions/View+.swift | Introduced the commitContextMenu extension to consolidate menu logic. |
Comments suppressed due to low confidence (2)
GitClient/Views/Folder/CommitGraph.swift:147
- Consider avoiding force unwrapping of 'folder' (folder!) to prevent potential runtime crashes. It might be beneficial to safely unwrap the variable or assert its presence before use.
.commitContextMenu(folder: folder!, commit: commit.commit, logStore: logStore, isRefresh: $isRefresh, showing: $showing, bindingError: $error)
GitClient/Views/Folder/CommitGraph.swift:163
- The duplicate invocation of commitContextMenu on both the GraphNode and GraphNodeText views may lead to overlapping context menu behavior. Consider consolidating these modifiers if only a single context interaction is intended.
.commitContextMenu(folder: folder!, commit: commit.commit, logStore: logStore, isRefresh: $isRefresh, showing: $showing, bindingError: $error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.