Skip to content

Add errorSheet that scrollable error text #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025
Merged

Add errorSheet that scrollable error text #112

merged 3 commits into from
Apr 25, 2025

Conversation

maoyama
Copy link
Owner

@maoyama maoyama commented Apr 25, 2025

Screenshot 2025-04-25 at 20 37 17

This pull request introduces a new error handling mechanism by replacing errorAlert with errorSheet across the codebase, alongside the addition of a new ErrorTextSheet component. It also updates the project configuration to include the new ErrorTextSheet.swift file.

Error Handling Updates:

  • Replaced errorAlert with errorSheet in various views, including ContentView, BranchesView, CommitCreateView, FolderView, and more. This change enables the use of a sheet-based error display instead of alerts for a more consistent user experience. [1] [2] [3] [4] and others)
  • Added a new ErrorTextSheet component to display error messages in a sheet with support for text selection and a dismiss button.
  • Updated the View extension to include the new errorSheet method, which uses ErrorTextSheet for error handling.

Project Configuration Updates:

  • Added ErrorTextSheet.swift to the project files in GitClient.xcodeproj/project.pbxproj to ensure it is included in the build process. [1] [2] [3] [4]

@maoyama maoyama merged commit 080fe3e into main Apr 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant