Commits count #107
Merged
Commits count #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new property `totalCommitsCount` to keep track of the total number of commits. - Updated existing methods to load the total commits count whenever commits are loaded or updated. - Ensured `totalCommitsCount` resets in `removeAll` method.
- Changed static text "1,000 Commits" to a dynamic count text using a new method `countText()`. - Added logic to display the correct singular or plural form based on the total commit count.
- Introduced a new struct `GitRevListCount` to encapsulate functionality for counting commits. - Updated project file to include the new source file.
…stCount - Trimmed whitespace from the output of stdOut in GitRevListCount's parse function to ensure accurate counting. - Updated loadTotalCommitsCount method in LogStore to use GitRevListCount when searchTokens are empty, improving efficiency.
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new feature to display the total commit count in the commit log view by introducing a backend command for counting commits, integrating the count into the observable log store, and updating the UI to show the count.
- Added the GitRevListCount command to execute "git rev-list --count".
- Enhanced LogStore to calculate and update totalCommitsCount during log retrieval and updates.
- Modified CommitLogView to display the commit count in a bottom inset.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| GitClient/Views/Folder/CommitLogView.swift | Added UI elements to show commit count using totalCommitsCount. |
| GitClient/Models/Observables/LogStore.swift | Integrated loadTotalCommitsCount call across log operations. |
| GitClient/Models/Commands/GitRevListCount.swift | Introduced a new command to parse commit count from git output. |
Files not reviewed (1)
- GitClient.xcodeproj/project.pbxproj: Language not supported
Comments suppressed due to low confidence (1)
GitClient/Models/Commands/GitRevListCount.swift:2
- The header comment still references 'GitRevList.swift' while the file is named 'GitRevListCount.swift'. Please update this comment to match the file name for clarity.
// GitRevList.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to display the total number of commits in the
CommitLogViewand includes the necessary backend and UI changes to support this functionality. The changes involve adding a new model for counting commits, updating theLogStoreobservable to calculate and store the count, and modifying the UI to display the count.Backend Changes:
Addition of
GitRevListCountCommand:GitRevListCountwas added to execute thegit rev-list --countcommand and parse its output to retrieve the total number of commits. (GitClient/Models/Commands/GitRevListCount.swift)GitRevListCount.swiftin the build sources. (GitClient.xcodeproj/project.pbxproj) [1] [2] [3] [4]Enhancements to
LogStoreObservable:totalCommitsCountproperty to store the count of commits. (LogStore.swift)loadTotalCommitsCountmethod to calculate the total commits count based on the current directory and search tokens. (LogStore.swift)logs(),update(), andremoveAll()to integrate the newloadTotalCommitsCountfunctionality. (LogStore.swift) [1] [2] [3] [4]UI Changes:
CommitLogView:CommitLogViewto include a bottom inset displaying the total number of commits. This uses thetotalCommitsCountproperty fromLogStore. (CommitLogView.swift)