-
Notifications
You must be signed in to change notification settings - Fork 7
Search token history #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Search token history #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced CommitLogView for displaying commit logs. - Added functionality for saving search token history. - Modified AppStorageKey and SearchKind to support new features. - Updated FolderView to include improved search suggestions.
- Replaced the List with CommitLogView for better encapsulation and maintainability. - Removed the logsRow function and moved the corresponding logic into CommitLogView. - Updated button actions for checkout and revert to utilize the new structure.
- Made newToken function public in SearchTokensHandler for better accessibility. - Updated saveSearchTokenHistory method in FolderView to accept old and new token values, replacing the previous single parameter implementation.
This reverts commit e7938a3.
This reverts commit 48d2299.
…or search kinds - Refactored `SearchKind` enum to implement `CaseIterable` and added label and help properties for each case. - Updated `FolderView` to utilize the new properties, improving search suggestion display with appropriate labels and descriptions.
- Removed onCheckout and onRevert closures, replacing them with a binding to isRefresh. - Updated the commit and revert actions to set isRefresh to true instead of calling the closures for refreshing models.
- Introduced a computed property `suggestSearchToken` to filter the decoded search token history, excluding the current search tokens. - Updated the search suggestions section to display filtered search tokens under 'History' when the search text is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#87
