[MAISTRA-1744] Route annotation propagation #11
Conversation
There was a problem hiding this comment.
Thank you @rtselizondo, this is pretty cool! 🙂
We'll need to document that Gateway annotations are passed through to the Route resources. Would you mind writing something up and filing a PR against maistra/maistra.github.io? There's a chapter on automatic Route creation already, it would just need another paragraph with an example.
|
Hello @dgn! Thanks 😄 I'm not familiar with how the documentation repo branches are managed. But I've created two PRs based on the version of Maistra. One for the Maistra 2.0 with that PR branch here: maistra/maistra.github.io#158 Each of the PRs point to their corresponding PR change based on version. Let me know if that makes sense. If you only need one, feel free to close the other one. |
|
I've also updated JIRA to have links to all the PRs here. https://issues.redhat.com/browse/MAISTRA-1744 |
|
closing as the |
Backport for version 1.2
This adds route annotation propagation to generated Openshift routes from Istio gateways. currently only excluding annotations from kubectl.kubernetes.io to reduce confusion. Could be more keys we would want to ignore, I'm open to discuss.
Changes allow use of https://github.com/tnozicka/openshift-acme specific annoations within Istio generated routes.
https://issues.redhat.com/browse/MAISTRA-1744
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure