Fix README with the correct list of PSR-17 packages #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the source, Mailgun uses `Discovery\Psr17FactoryDiscovery` and `Psr18ClientDiscovery`; thus, docs should like to factory and not message implementations. Related to mailgun#889.
7b87b45 to
6c79b47
Compare
oleksandr-mykhailenko
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the source, Mailgun uses
Discovery\Psr17FactoryDiscoveryandPsr18ClientDiscovery; thus, docs should like to factory and not message implementations.Edit: just noticed that the mysterious package forced in my dependencies is indeed a provider of
psr/http-factory-implementation, so it looks like my guesses for this commit seem correct 😂Related to #889.